Fallout-build/Fallout

Rename legacy s_-prefixed private fields to camelCase and enforce the rule

クローズ

#481 opened on 2026/07/12

 (3 件のコメント) (0 件のリアクション) (0 人の担当者)C# (16 件のフォーク)github user discovery
enhancementgood first issuetarget/backlog

Repository metrics

Stars
 (125 個のスター)
PR merge metrics
 (平均マージ 2d 15h) (30d で 63 merged PRs)

説明

Problem

.editorconfig:73-85 mandates camelCase private fields (no _/m_/g_/s_ prefix, per CSharpGuidelines AV1702/AV1705) but keeps severity = suggestion because ~35 legacy s_-prefixed identifiers across ~34 files still violate it (e.g. Telemetry.s_confirmedVersion). The convention is documented but not compiler-enforced, so new violations slip in. Surfaced in #451 review.

Outcome

No prefixed private fields remain; the naming rule is warning, so new violations fail the build.

Acceptance criteria

  • All s_/_/m_/g_-prefixed private fields in src/**/*.cs renamed to camelCase
  • dotnet_naming_rule.private_fields_should_be_camel_case.severity bumped suggestionwarning (.editorconfig:78)
  • Build green with no new naming warnings

Notes

Mechanical rename; exclude generated code. Low priority.

コントリビューターガイド