Ebazhanov/cypress-ui-api-tests

Implement changes based on the provided feedback

Open

#1 opened on 2025年6月15日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)TypeScript (0 forks)github user discovery
good first issue

Repository metrics

Stars
 (2 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

Feedback:

ask 1:

  • simple structure and readability ~ very basic functional and not functional testing coverage ~ findings reported, although info is minimal (no proper description, steps to reproduce, additional info like screenshots/video..)
  • No reasoning for the priority set
  • No risks analysis

Task 2:

  • Simple implementation of the UI task
  • use of beforeEach to handle repetitive actions
  • coverage of core operations
  • Improvable readability
  • No clean project structure (tasks are mixed in the same folder, many files in the main root that should be moved to dedicated task’s folder.
  • Missing dedicated Readme addressing the challenge’s requirements
  • Hardcoded values
  • Tests are dependent on each other for their correct execution.

Task 3:

  • use of custom commands
  • Core functionality coverage
  • use of dynamic names
  • assertion of API response
  • utility functions used
  • parameterisation of commands
  • no error handling
  • Tests are dependent on each other
  • Hardcoded values

コントリビューターガイド