CommunityToolkit/WindowsCommunityToolkit
GitHub ã§èŠã[Sample App] Commands for Sample Pages should have more options for manipulation
Open
#1,960 opened on 2018幎4æ9æ¥
help wantedno-recent-activity :chart_with_downwards_trend:sample app ðŒ
Repository metrics
- Stars
- Â (5,708 stars)
- PR merge metrics
-  (30d ã« merged PR ã¯ãããŸãã)
説æ
I'm submitting a...
- Sample app request
Should be related to general improvements #1438 and originally needed by PR #1896.
Current behavior
A sample page can only add new commands for the sample at the commandbar, but outside of the user clicking to invoke them has no way to interact with the button. This makes it hard to enable/disable buttons, hide/show buttons, or have toggle buttons.
Expected behavior
We should extend the SampleCommand and RegisterNewCommand paradigms to allow for:
- Returning the
SampleCommandonRegisterNewCommand - Shell CommandBar listens to updates to properties for
Labeland newParameter,IsVisible, andIsEnabledproperties on theSampleCommand - P2: Provide the option when registering to set the button type to a 'togglable' one.