CleverRaven/Cataclysm-DDA

Tests: `guy != nullptr` randomly failing

Open

#73,352 opened on 2024年4月28日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)C++ (9,264 stars) (3,991 forks)batch import
<Bug>Code: TestsHelp Wanted[C++]

説明

Describe the bug

In all listed cases are also some armor display tests failing and this may be related. This specific random failure appears to be comparatively rare.

Unfortunately I lack the privileges in this repo to search through all workflow logs but I feel like I have seen this before. Can't prove it with additional links though.

Attach save file

Steps to reproduce

  1. Run tests.
  2. Win the rng lottery.
  3. Witness above failure.

Expected behavior

guy != nullptr

Screenshots

No response

Versions and configuration

n/a

Additional context

No response

コントリビューターガイド

技術スタック
cpp
領域
testing
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
C++ basicstest suite familiaritydebugging skillsgame logic understanding
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
Examine the workflow logs linked in the issue to identify the exact assertion and stack trace. Search the test code for `guy != nullptr` to understand the context. Investigate the relationship between this test and the armor display tests that also fail randomly. Check if there is a race condition or missing initialization of the `guy` variable. Consider running the test multiple times locally to reproduce.