Carthage/Carthage

Carthage update could give different results per run with Swift 4.2

Open

#2,487 opened on 2018年6月15日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)Swift (15,179 stars) (1,544 forks)batch import
help wanted

説明

It seems like the order in which dependencies are processed depends on the hash value of the dependency. Since hash values are stable with the current implementation of Swift and Carthage, this "undefined" order remains consistent across runs. However, Swift 4.2 will add random elements to default hashes, which means that the result of carthage update could be different across runs (see https://github.com/apple/swift-evolution/blob/master/proposals/0206-hashable-enhancements.md#proposed-solution).

A side benefit of providing a pre-defined order is it will be easier to create tests that exercise problems that will fail (or pass) consistently.

コントリビューターガイド

技術スタック
swift
領域
build systemdeveloper experience
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Familiarity with CarthageBasic Swift knowledgeUnderstanding of hash functions
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
The issue discusses non deterministic build order due to random hashing in Swift 4.2. A fix would involve imposing a deterministic order on dependency processing, likely in the dependency resolution logic. Look at the Carthage source code, specifically files related to dependency resolution and ordering, such as `CarthageKit/Project.swift`. Search for existing discussions or PRs tagged with this issue to understand maintainer expectations.