Carthage/Carthage

Cache failing to resolve dependencies with name collision

Open

#2,150 opened on 2017年9月8日

GitHub で見る
 (10 comments) (0 reactions) (0 assignees)Swift (15,179 stars) (1,544 forks)batch import
bugcheckouthelp wanted

説明

Carthage keeps a cache of fetched dependencies in ~/Library/Caches/org.carthage.CarthageKit/dependencies/….

Assuming you have a project with this in its Cartfile:

github "antitypical/Result"

And another project with this:

github "somebody/Result"

Then due to not using any further subdirectories for antitypical or somebody carthage ends up fetching the wrong dependency from the local cache for the second project being bootstrapped.

This pretty much defeats the whole point of supporting namespacing in the first place. 😢

コントリビューターガイド

技術スタック
swift
領域
toolingbuild system
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Understanding of Carthage's caching mechanismFamiliarity with dependency resolver design
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Investigate the cache directory structure in Carthage, likely in `~/Library/Caches/org.carthage.CarthageKit/dependencies/`. The current implementation uses only the dependency name without the namespace (e.g., account/repo). This causes collisions when two repos have the same name from different owners. The fix would involve including the namespace in the cache path, e.g., using a subdirectory per owner. Look at the source code for cache handling in Carthage, possibly in `CarthageKit` or `Project` files. The issue has 10 comments with potential discussion on solutions; review those for proposed approaches.