Byron/trash-rs

[feat] Map Windows errors

オープン

#96 opened on 2024/01/10

 (6 件のコメント) (0 件のリアクション) (0 人の担当者)Rust (40 件のフォーク)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (247 個のスター)
PR merge metrics
 (PR metrics pending)

説明

It appears that all windows::core::Error's are mapped to trash::Error::Unknown (code here). Is it possible to use the error code (ref) to map at least some of the more common errors to the corresponding trash::Error variant?

e.g. codes 2 and 3 could map to trash::Error::FileSystem with an error kind of std::io::ErrorKind::NotFound.

Another option could allow for the Unknown variant to also accept an optional error code, but that doesn't feel like the correct way to go about it.

Happy to give implementation a shot if it seems like a good idea.

コントリビューターガイド