B-Lang-org/bsc

Generate appropriate empty argument lists for Verilog system tasks/functions

オープン

#304 opened on 2021/02/03

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Haskell (178 件のフォーク)batch import
good first issuepre-github

Repository metrics

Stars
 (1,108 個のスター)
PR merge metrics
 (平均マージ 17d 1h) (30d で 18 merged PRs)

説明

When system tasks appear in the generated Verilog, this code in Verilog.hs omits the parenthesis when there are no arguments:

-- no parens when calling a task if it has no arguments                                                                                   
pPrint d p (VTask task []) = pPrint d 0 task <> text ";"

This was probably added because that is how the Verilog standard says that $finish should be written. However, for $fflush, the standard says that it must have empty parentheses, and some tools will be sticklers and issue a warning if the parentheses are missing.

The pPrint code will probably need to check the task name, to handle each specifically.

This is bug 1925 in Bluespec Inc's pre-GitHub bug database.

コントリビューターガイド