appimagetool follows symlinks outside of the AppImage for determining architecture · AppImage/AppImageKit#546

(4 comments) (0 reactions) (0 assignees)C (8,239 stars) (547 forks)batch import

buggood first issue

説明

/home/me/squashfs-root/opt/cxoffice/support/apps.com.qq.im.light/dosdevices/f:/boot/grub/x86_64-efi/test.mod used for determining architecture x86_64
/home/me/squashfs-root/opt/cxoffice/support/apps.com.qq.im.light/dosdevices/f:/boot/grub/x86_64-efi/lspci.mod used for determining architecture x86_64
/home/me/squashfs-root/opt/cxoffice/support/apps.com.qq.im.light/dosdevices/f:/boot/grub/x86_64-efi/usb_keyboard.mod used for determining architecture x86_64
/home/me/squashfs-root/opt/cxoffice/support/apps.com.qq.im.light/dosdevices/f:/boot/grub/x86_64-efi/hexdump.mod used for determining architecture x86_64
/home/me/squashfs-root/opt/cxoffice/support/apps.com.qq.im.light/dosdevices/f:/boot/grub/x86_64-efi/true.mod used for determining architecture x86_64
/home/me/squashfs-root/opt/cxoffice/support/apps.com.qq.im.light/dosdevices/f:/boot/grub/x86_64-efi/usbserial_common.mod used for determining architecture x86_64

@teras when packaging an AppImage that contains a WINEPREFIX which links outside of the AppImage, then it tries to determine architectures outside of the AppImage.

It should not follow symlinks to determine the architecture, let alone symlinks that point to the outside of the AppImage.

コントリビューターガイド

技術スタック: c
領域: desktoptooling
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: stale
明確さ: clear
前提条件: C programmingunderstanding of symlinksfamiliarity with AppImage tooling
初心者向け度: 40
調査方針: The issue is in appimagetool's architecture detection logic. The tool currently reads ELF files to determine architecture but follows symlinks, including those pointing outside the AppImage. The fix should ensure that symlinks are not followed when scanning for ELF files. Look in the appimagetool source code (likely in src/ or similar) for functions that traverse the filesystem to find ELF files. Modify them to skip symlinks or to not follow them. Check existing comments or linked PRs for additional context.