AllenFang/react-bootstrap-table

Extend filters to allow html attributes to be passed down

Open

#1,715 opened on 2017年10月26日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)JavaScript (795 forks)batch import
help wantedin progress

Repository metrics

Stars
 (2,240 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

Hello. Currently it appears there is no way to add an html attribute to the underlying markup that is generated by the built-in filters such as <SelectFilter>.

My use-case would be adding an id, data, or aria attribute to the html elements such as a <select>.

Attributes are passed to the component in the JSX. https://github.com/AllenFang/react-bootstrap-table/blob/281db991c08f1d4cad2c522b13875a97d2e27e0f/src/TableHeaderColumn.js#L70

But they aren't shared with the HTML elements. https://github.com/AllenFang/react-bootstrap-table/blob/281db991c08f1d4cad2c522b13875a97d2e27e0f/src/filters/Select.js#L98-L104

I'm happy to submit a PR if you agree with the use.

コントリビューターガイド