AdguardTeam/AdGuardHome

Rewrite networking in package dhcpd to only use gopacket

Open

#4,923 opened on 2022年9月15日

GitHub で見る
 (0 comments) (1 reaction) (1 assignee)Go (34,000 stars) (2,333 forks)batch import
P3: Mediumenhancementexternal libshelp wantedresearch

説明

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

Description

What problem are you trying to solve?

Package dhcpd currently uses a lot of different modules and packages for networking, including github.com/google/gopacket, github.com/insomniacslk/dhcp, github.com/mdlayher/ethernet, and the deprecated github.com/mdlayher/raw. This creates all sorts of issues, including but not limited to:

  1. portability;
  2. API compatibility;
  3. difficulty of package update and maintenance.

Proposed solution

Module github.com/google/gopacket seems to have either all or most of the things we require. If I am not mistaken, we could even enable DHCP on Windows, if we make sure that the networking works well there.

Alternatives considered

Go on as we do. See the problems with this approach above.

コントリビューターガイド

技術スタック
go
領域
backend
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
over 1 week
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Gonetworking fundamentalsgopacket libraryAdGuardHome DHCP module
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
Examine the current networking code in the 'dhcpd' package to identify all usages of 'github.com/insomniacslk/dhcp', 'github.com/mdlayher/ethernet', and 'github.com/mdlayher/raw'. Then, research how to replace each with 'github.com/google/gopacket' equivalents. Pay special attention to Windows compatibility as mentioned in the issue. Since the issue is assigned, it may be worth checking the assignee's progress or discussing with maintainers to avoid duplication.
Rewrite networking in package dhcpd to only use gopacket · AdguardTeam/AdGuardHome#4923 | Good First Issue