AbsaOSS/enceladus

Refactor Validation Utils

オープン

#57 opened on 2018/12/02

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)Scala (16 件のフォーク)auto 404
Conformancegood first issuepriority: undecidedrefactoring

Repository metrics

Stars
 (33 個のスター)
PR merge metrics
 (PR metrics pending)

説明

We have two separate ValidationExceptions:

  • za.co.absa.enceladus.conformance.interpreter.rules.ValidationException (only used in Standardization)
  • za.co.absa.enceladus.utils.validation.ValidationException (only used in Conformance) Conformance also dips into za.co.absa.enceladus.utils.validation.ValidationUtils before throwing its own ValidationException, which blurs the line between which ValidationException is responsible for what.

Good design dictates a clear separation between the two or a unification.

There is also some code duplication in conformance rules, specifically aimed at validation, that would best be extracted to a common location.

コントリビューターガイド