123ishaTest/ludiek

Reconsider `amount` for input and output

オープン

#84 opened on 2025/08/19

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)TypeScript (4 件のフォーク)auto 404
good first issuehelp wanted

Repository metrics

Stars
 (12 個のスター)
PR merge metrics
 (PR metrics pending)

説明

#83 introduced input and output. While very useful, the amount property can sometimes be awkward as it doesn't make sense for all resources (e.g. AchievementOutput)

Consider refactoring it to also implement a getAmount() which defaults to input.amount if it's available and if not errors. Basically ensure that one is implemented. Can also already be done at engine construction

コントリビューターガイド