itzg/minecraft-server-charts

Missing values in helm templates

Open

#141 opened on Jan 24, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Mustache (165 forks)github user discovery
good first issuehelp wanted

Repository metrics

Stars
 (391 stars)
PR merge metrics
 (PR metrics pending)

Description

In the helm chart, two values are missing, as previously added in Minecraft bedrock. https://github.com/itzg/docker-minecraft-bedrock-server/blob/ab51be217cf5f245fcb3239466f145af3a9422ba/property-definitions.json#L112

https://github.com/itzg/docker-minecraft-bedrock-server/blob/ab51be217cf5f245fcb3239466f145af3a9422ba/property-definitions.json#L116

I did not find those two values can be easily controlled in the helm chart values.

  "emit-server-telemetry": {
    "env": "EMIT_SERVER_TELEMETRY",
    "allowed": ["true","false"]
  },
  "enable-lan-visibility": {
    "env": "ENABLE_LAN_VISIBILITY",
    "allowed": ["true","false"]
  }

I expect this feature can be added.

Contributor guide

Research direction
Add two environment variable mappings for 'emit server telemetry' and 'enable lan visibility' to the Helm chart's values.yaml and templates, following the pattern of existing properties.
Tech stack
go
Domain
devopsinfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
HelmKubernetes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70