itzg/docker-minecraft-server

Support `*.jar.disabled` mods

Open

#3,144 opened on Nov 9, 2024

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Shell (1,858 forks)batch import
enhancementhelp wantedtype/curseforgetype/modrinth

Repository metrics

Stars
 (13,694 stars)
PR merge metrics
 (Avg merge 15h 10m) (32 merged PRs in 30d)

Description

Enhancement Type

A completely new feature

Describe the enhancement

Some launchers allow you to disable installed mods as a way to prevent it from being used and not having to fully remove it. I usually use this if I'm testing things and likely want to return to using the mod after tests. If I was to do this with the image now, it would just redownload the mod that was renamed .jar.disabled.

I was wondering the possibility of supporting this file naming as an alternative to the mod's expected filename? That way the system recognizes that the mood is there and doesn't redownload it.

Contributor guide

Research direction
Inspect the mod downloading and validation script in the Docker image startup to identify where mods are checked for existence. Explore how filenames are matched and consider allowing `.jar.disabled` as a valid format so the image does not re download disabled mods. Also add a test if possible.
Tech stack
dockershell
Domain
backenddevops
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ShellDockerGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65