[Bug] Il componente <it-dropdown-item> non risulta davvero disabilitato

Open Beginner friendly
#723 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
angular, typescript
Domain
frontend

Research direction

Start by locating the it-dropdown-item component and the itDropdownItem directive, then reproduce the provided Angular example with disabled="true". Trace how click events are handled for disabled items and verify that onClick() is not called in either usage when the disabled state is set.

Written by the indexing model from the issue text.

Description

Esiste già una discussione sul tema che ti interessa, o su un tema simile?
  • Ho verificato e non esiste
Versione della libreria

v21.0.0

Cosa

Il componente, sebbene sia disabilitato, risulta ugualmente cliccabile

<!-- `onClick()` viene chiamato nonostante `disabled` sia `true` -->
<it-dropdown-item
  mode="button"
  disabled="true"
  (click)="onClick()"
>
  Click me!
</it-dropdown-item>
Perché

è un grosso limite, in quanto non tutti gli <it-dropdown-item> vengono utilizzati come link

Contesto

No response

Altro

Il problema si presenta anche con l'utilizzo della direttiva itDropdownItem

Dominant language
TypeScript
Stars
86
Forks
45
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from italia/design-angular-kit

All issues in italia/design-angular-kit

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.