zulip/zulip-mobile

Debug AnimatedComponent getting stuck with rapid changes in state

Aperta

#3899 aperta il 12 feb 2020

 (4 commenti) (0 reazioni) (0 assegnatari)JavaScript (673 fork)github user discovery
experimental UI/UXhelp wanted

Metriche repository

Star
 (1348 stelle)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

Good animations can go a long way to smooth out rough edges, and currently we're being blocked from using more of them.

876f22d1aec9580ac053849b2c0ffaf1891b99fb reverted the use of AnimatedComponent for the OfflineNotice because of this issue:

When disconnecting from a VPN on Android 9 and later, the connection state goes from 'vpn' to 'none' to 'wifi' very quickly. This can result in the online banner getting stuck in mid-animation, until some other event (e.g. the user scrolling) causes a redraw.

I haven't had time to reproduce it, yet, but we'll need a consistent reproduction before we can continue using AnimatedComponent. I'd especially like to use it for a loading banner in https://github.com/zulip/zulip-mobile/issues/3387.

Guida contributor