zephyrproject-rtos/zephyr

Port drivers to use sys/ring_buffer

Chiusa

#21.155 aperta il 3 dic 2019

Vedi su GitHubGuida contributor
 (8 commenti) (0 reazioni) (0 assegnatari)C (9144 fork)batch import
EnhancementGood first issuearea: Drivers

Metriche repository

Star
 (15.249 stelle)
Metriche merge PR
 (Merge medio 4g 21h) (1000 PR mergiate in 30 g)

Descrizione

There are some drivers that are implementing their own ring_buffer, there are cases where even functions names are colliding with sys/ring_buffer.

Drivers doing it: drivers/ethernet/eth_sam_gmac.c drivers/i2s/i2s_sam_ssc.c drivers/i2s/i2s_ll_stm32.h

Guida contributor

Direzione di ricerca
Examine the three listed driver files (eth sam gmac.c, i2s sam ssc.c, i2s ll stm32.h) to identify their custom ring buffer implementations. Replace each with the generic sys/ring buffer from the Zephyr kernel, ensuring function name collisions are resolved and the existing behavior is preserved. Check for any usage of the old ring buffer functions in header files or other modules, and update accordingly. Verify compilation and run relevant tests to ensure no regressions.
Tech stack
c
Dominio
backend
Tipo issue
Refactoring
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 giorni
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Datata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
Basic knowledge of CFamiliarity with Zephyr driver modelUnderstanding of ring buffer API
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
30