zephyrproject-rtos/zephyr

Drop Futile BUILD_ASSERTs in tmc5xxx series

Chiusa

#109.856 aperta il 26 mag 2026

Vedi su GitHubGuida contributor
 (2 commenti) (1 reazione) (1 assegnatario)C (9144 fork)batch import
Good first issuearea: Stepper

Metriche repository

Star
 (15.249 stelle)
Metriche merge PR
 (Merge medio 4g 21h) (1000 PR mergiate in 30 g)

Descrizione

Summary

stallguard_threshold_velocity is actually part of adi,tmc5xxx-stepper-ctrl bindings. https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/dts/bindings/stepper/adi/adi%2Ctmc50xx-stepper-ctrl.yaml#L10 https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc51xx/tmc51xx_stepper_ctrl.c#L493

However, couple of other drivers in the tmc5xxx series do BUILD_ASSERT on this property. The ASSERT never actually happens since it's guarded by a COND_CODE_1, which would never be tree, hence it's actually futile.

https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc51xx/tmc51xx.c#L528-L530

Describe the solution you'd like

Drop the ASSERTs listed below.

  1. https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc51xx/tmc51xx.c#L528-L530

  2. https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc51xx/tmc51xx_stepper_driver.c#L205-L207

  3. https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc50xx/tmc50xx_stepper_driver.c#L170-L172

Alternatives

No response

Additional Context

No response

Guida contributor

Direzione di ricerca
The issue involves removing three futile BUILD ASSERT macros from files: drivers/stepper/adi tmc/tmc51xx/tmc51xx.c (lines 528-530), drivers/stepper/adi tmc/tmc51xx/tmc51xx stepper driver.c (lines 205-207), and drivers/stepper/adi tmc/tmc50xx/tmc50xx stepper driver.c (lines 170-172). The asserts are guarded by COND CODE 1 on a property that never exists, so they are dead code. The fix is to delete those lines. The issue is assigned but has no open PR, so check assignee status before starting.
Tech stack
c
Dominio
backend
Tipo issue
Refactoring
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
Meno di 1 ora
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Bloccata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
C programming
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40