zalmoxisus/redux-devtools-extension

Sets aren't properly diffed or displayed

Aperta

#452 aperta il 30 gen 2018

 (1 commento) (8 reazioni) (0 assegnatari)JavaScript (1011 fork)batch import
help wantedmonitor

Metriche repository

Star
 (13.454 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Just wanted to make you aware of a possible bug. When passing a new set as a key of the initial state:

{
  items: new Set()
}

and then later adding to the set like so:

const newItems = new Set(state.items)
newItems.add("newItem")
return {...state, items: newItems}

the redux devtools evaluates the diff as no change, while logging the state shows that an item was added.

Let me know if you want any more details about this bug. I have a workaround that I'm using to log the items when needed, but thought you might want to know.

Guida contributor