area/docdbgood first issuekind/enhancementpriority/medium
Metriche repository
- Star
- (8229 star)
- Metriche merge PR
- (Merge medio 17g 21h) (92 PR mergiate in 30 g)
Descrizione
Jira Link: DB-1508
Despite this methods name, we seem to have used this method in void TabletServiceAdminImpl::FlushTablets
void Tablet::ForceRocksDBCompactInTest() {
if (regular_db_) {
docdb::ForceRocksDBCompact(regular_db_.get());
}
if (intents_db_) {
CHECK_OK(intents_db_->Flush(rocksdb::FlushOptions()));
docdb::ForceRocksDBCompact(intents_db_.get());
}
}
One obvious issue with this method in production code is the use of CHECK_OK. This only affects admin CLI flush commands, so this isn't a huge deal, but we should fix this regardless and ensure there are no other obvious or subtle issues with using this in production
cc @spolitov