xtermjs/xterm.js

Search is too slow

Chiusa

#5176 aperta il 3 ott 2024

Vedi su GitHubGuida contributor
 (34 commenti) (4 reazioni) (0 assegnatari)TypeScript (1574 fork)batch import
area/addon/searcharea/performancehelp wantedtype/bug

Metriche repository

Star
 (16.196 stelle)
Metriche merge PR
 (Merge medio 2g 10h) (16 PR mergiate in 30 g)

Descrizione

Currently the search addon limits itself to 1000 highlights by default. Contrast this to monaco's 20000 results before it gives up highlighting. When we increase our limit to 20000 the search itself ends up blocking the renderer pretty significantly.

Here is a profile using my i7-12700KF 3.61 GHz:

test file test.txt

Image

Image

Note that the search is also not incremental, so all successive searches take the same amount of time even for non-regex searches. https://github.com/xtermjs/xterm.js/issues/5177

VS Code issue: https://github.com/microsoft/vscode/issues/230365

Guida contributor

Direzione di ricerca
Investigate the search addon in xterm.js (likely in addons/search/). The issue shows that increasing the highlight limit causes renderer blocking; profile the search function to identify bottlenecks. Consider implementing incremental search to avoid re searching non regex queries (see linked issue #5177). Evaluate using a web worker to offload search computation. The test file provided can be used to reproduce the slowdown.
Tech stack
typescript
Dominio
frontendperformance
Tipo issue
Performance
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
Mezza giornata
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Attiva
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Abbastanza chiara
Prerequisiti
Familiarity with xterm.js search addonBasic profiling skills
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60