winstonjs/winston
Vedi su GitHubFile logging reconfiguration issue (Error: write after end)
Open
#1573 aperta il 23 gen 2019
BugGood First IssueHelp WantedImportant
Metriche repository
- Star
- (21.967 star)
- Metriche merge PR
- (Merge medio 68g 4h) (9 PR mergiate in 30 g)
Descrizione
Please tell us about your environment:
winstonversion?-
winston@2 - [ X]
winston@3
-
- _
node -voutputs:_v10.15.0 - _Operating System?_Windows 10
- _Language? JavaScript (pure Node)
What is the problem?
When logger is reconfigured, the open streams are destroyed and winston tries to write to an already destroyed stream.
I created a really simple playground to replicate it (less than 10 lines of actual code): https://github.com/peterbakonyi05/winston-log-rotate-reconfiguration-issue/blob/master/index.js
What do you expect to happen instead?
winston creates a new stream and handles reconfiguration.
Note
Alternatively, instead of reconfiguring winston a new instance can be created, in case someone else has the same issue. Just call .close on the old instance and create a new from scratch.