winglang/wing

PR linter

Open

#482 aperta il 7 nov 2022

Vedi su GitHub
 (4 commenti) (0 reazioni) (0 assegnatari)TypeScript (214 fork)github user discovery
good first issue👷‍♀️ contributor-experience

Metriche repository

Star
 (5385 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

PRs that change certain things should require new/changed example wing files to ensure coverage is available for the various tests that consume those files.

Feature Spec

Suggested projects to require test cases:

  • tree-sitter-wing
  • wingc (maybe only certain files, like the parser/typechecker/jsify)

Use Cases

Testing is often easy to forget, but for such foundational changes, we should nudge contributors to add bare minimum testing.

Implementation Notes

I think it would be interesting to look into generic tooling to support PR lints. e.g. https://danger.systems/js/

Also note we use mergify, which can also help

Component

  • Development Environment
  • Contributor Experience

Guida contributor