wildfly-security/wildfly-elytron-hashicorp-vault

Consider KV version utilities and enum in main code

Aperta

#81 aperta il 19 giu 2026

 (0 commenti) (0 reazioni) (0 assegnatari)Java (7 fork)auto 404
good first issue

Metriche repository

Star
 (0 stelle)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

The KvVersionTestHelper class in test code contains a KvVersion enum and utilities that handle differences between KV v1 and v2:

KvVersion enum (V1/V2 with version numbers) Path construction for different versions (constructApiPath) Path validation (isValidPathForVersion) Secret name extraction (extractSecretName) Currently the main code handles KV version differences using string comparisons and inline logic. Having a proper enum and centralized utilities in production code would improve type safety and maintainability.

Considerations:

Separate test-specific methods (CLI, containers) from general utilities Main code would benefit from enum-based version handling Requires design discussion on production utility patterns Related: PR #71 review feedback

Guida contributor