whatwg/html

Small clarity improvements to canvas transform methods

Aperta

#2848 aperta il 19 lug 2017

 (7 commenti) (1 reazione) (0 assegnatari)HTML (2520 fork)batch import
clarificationgood first issuetopic: canvas

Metriche repository

Star
 (7654 stelle)
Metriche merge PR
 (Merge medio 42g 18h) (22 PR mergiate in 30 g)

Descrizione

While in the area for #2845, I noticed the following small tweaks that we could make to improve that section of the spec:

  • Replace "abort these steps" with "return" everywhere. (The latter is a more modern convention, per Infra.)
  • Link "multiplying" in the definition of transform(a, b, c, d, e, f) to https://drafts.fxtf.org/geometry/#matrix-multiply
  • Re-do setTransform(a, b, c, d, e, f) steps 2-3 to reset the current transformation matrix to the appropriate matrix (a c e / b d f / 0 0 1), instead of resetting the matrix to the identity matrix then invoking the transform() method. It's bad practice to invoke methods from other methods.

This is a good first bug :)

Guida contributor