welldone-software/why-did-you-render

Show line where hook that changed is used (feature request)

Open

Aperta il 27 apr 2021

Vedi su GitHub
 (3 commenti) (4 reazioni) (0 assegnatari)JavaScript (10.560 star) (188 fork)batch import
enhancementgood first issuehelp wanted

Descrizione

I currently have a very big hook, with dozens of useStates, lots of them have empty arrays which trigger unncesary re-renders. But I don't know which is the one doing it each time wdyr logs it's output. I get:

Re-rendered because of hook changes: 
[hook useState result]
...diff

When would be very useful for me is:

Re-rendered because of hook changes:
[hook useState result] (someRandomHook.ts:34)
...diff

Knowing which hook is changing would be useful, specially in nested hooks scenarios, for example I have a hook which uses a hook, and that internal one has state, but wdyr does not even specify which hook is that useState from (I guess react makes no distinction, it only cares about hook declaration order, so not sure how possible would this feature request be.)

Guida contributor

Tech stack
javascriptreact
Dominio
performancedeveloper experience
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Understanding of React hooksFamiliarity with why did you render library source code
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
50
Direzione di ricerca
The issue requests to show the file and line number where a hook change originates. Start by examining the library's core files, particularly how it patches useState and other hooks (e.g., in src/monitorHooks.js or similar). Look for any existing stack trace collection or the ability to add Error().stack to capture the call site. Note that React does not naturally provide this info, but you could use a custom wrapper or monkey patch. Check if there are any comments or related PRs (none linked). A concrete approach: modify the hook patching to wrap the state setter with a function that captures the stack when called, then include that in the log output. Be aware of performance implications.