vuejs/vue-router

The type definition of Route seems to be partially wrong

Open

Aperta il 9 giu 2021

Vedi su GitHub
 (4 commenti) (0 reazioni) (0 assegnatari)JavaScript (19.015 star) (5092 fork)batch import
Typescriptcontribution welcomefixed on 4.xgood first issue

Descrizione

Version

3.5.1

Reproduction link

https://github.com/vuejs/vue-router/blob/dev/types/router.d.ts#L203

Steps to reproduce

None, just the source code seems to be wrong.

What is expected?

The type definition of Route#query should be

query: Dictionary<string | null | (string | null)[]>

The current implementation cannot express this type of query

/path?foo#bar

as it doesn't have any value and it is not converted to an array.

What is actually happening?

https://github.com/vuejs/vue-router/blob/dev/types/router.d.ts#L203

The type definition of Route#query is

query: Dictionary<string | (string | null)[]>

Guida contributor

Tech stack
typescriptvue
Dominio
frontend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
basic TypeScript understanding
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
85
Direzione di ricerca
The issue points to a specific line in types/router.d.ts (line 203) where the Route#query type is defined as Dictionary<string | (string | null)[]>. The expected change is to include string | null as an option for the dictionary value, making it Dictionary<string | null | (string | null)[]>. This is a simple type correction. No discussion or PRs are linked. The fix should be applied to the same file.