vuejs/vue-router

Throw exception or provide info message when route's component is null

Open

Aperta il 31 gen 2018

Vedi su GitHub
 (9 commenti) (0 reazioni) (0 assegnatari)JavaScript (19.015 star) (5092 fork)batch import
contribution welcomefeature requestgood first issue

Descrizione

What problem does this feature solve?

Currently, route's component can be null and it give no information and error. Provide information or raising error can help users to catch they have some import issues when they use

import * as components from './components'

export default [
  {
    path: '/accounts',
    component: components.AccountsListView,
    name: 'accountsListView'
  },
  {
    path: '/accounts/create',
    component: components.CreateEditAccounts,
    name: 'createAccounts'
  }
]

So if components.CreateEditAccounts is null, they will know what went wrong easier.

What does the proposed API look like?

Raise error when component is null or log info message.

Guida contributor

Tech stack
javascriptvue
Dominio
frontend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
JavaScriptVue Router basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
75
Direzione di ricerca
Investigate the route configuration parsing logic in the vue router source, likely in `src/create matcher.js` or similar. Add a null check for the `component` property and either log a warning or throw an error with a descriptive message. Review the comments on the issue for any additional context or proposed solutions. Check existing tests to ensure no breaking changes.