voxel51/fiftyone

[FR] Map plugin enhancements

Open

#1994 aperta il 11 ago 2022

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)Python (400 fork)batch import
appenhancementgood first issue

Metriche repository

Star
 (4021 star)
Metriche merge PR
 (Merge medio 3g 11h) (161 PR mergiate in 30 g)

Descrizione

Enhancement requests for the (awesome) map plugin introduced in #1976:

ESC handling

Currently, pressing ESC when any component of the App is in focus (grid, sidebar, etc) will cause the map's location to be reset. Ideally the map would only be reset when the map has focus.

For example, the user might have selected a sample but then wants to press ESC to clear the selection. Currently both the selection and the map will be reset simultaneously.

On a related note, while in the middle of defining a selection region, pressing ESC currently simultaneously resets the selection (good) but also resets the map's view (ideally this would require a second ESC).

Geo-based queries

Map lasso selections are currently encoded via select() stages. But, it would be more natural and space-efficient to express them using the geo_within() query defined by the selection area that the user inputted. Example geo_within() usage.

A second, related optimization would be to combine multiple searches into a single stage. IE if I perform three selections and then press the bookmark icon, I'd like to see only a single GeoWithin stage added to my view bar. Currently I will see multiple Select() stages added. The merging of multiple selections into a single stage could be implemented independent of whether Select() or GeoWithin() is used to represent the query. this is already done, at least for the current Select() based implementation

Guida contributor