vercel/next.js

ISG with GIP in _app overrides cache-control of ISG page

Open

Aperta il 16 giu 2020

Vedi su GitHub
 (3 commenti) (0 reazioni) (1 assegnatario)JavaScript (139.471 star) (31.066 fork)batch import
Pages Routergood first issuetype: next

Descrizione

Bug report

When using the unstable_revalidate param with ISG, a header set by _app should never win.

Additional context

From @lfades:

Update: this is currently not the case, SSG finishes the request before it gets to _app.

the custom _app in the Next.js site was setting a header, but that causes an error because the request was sent, this happens in production and with next start, but in dev you don't get any error.

Guida contributor

Tech stack
nextjsreactjavascripttypescript
Dominio
full stack
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
blocked
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Next.jsISGgetInitialPropscache control
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
30
Direzione di ricerca
Investigate how Next.js handles cache control headers when using ISG with getInitialProps in app. Look at the source files related to ISG, such as next server and router. A minimal reproduction would help confirm the issue. Check if there are existing tests for this scenario in the Next.js test suite.