Regression: dynamic runtime `require` works in 0.38.1 but breaks in 0.38.2

(2 commenti) (0 reazioni) (0 assegnatari)JavaScript (273 fork)batch import

help wanted

Metriche repository

Star: (8841 stelle)
Metriche merge PR: (Merge medio 31g 15h) (7 PR mergiate in 30 g)

Descrizione

0.38.1

I have the following source code:

https://github.com/CatChen/eslint-suggestion-action/blob/930479a34a06bfa384291cc877f9d1ce21533ae1/src/getESLint.ts#L16-L19

The dynamic require is compiled into the following code:

https://github.com/CatChen/eslint-suggestion-action/blob/930479a34a06bfa384291cc877f9d1ce21533ae1/bundle/index.js#L37587

0.38.2

The same code is compiled into the following code since 0.38.2:

https://github.com/CatChen/eslint-suggestion-action/blob/bc0de7fa625de9daf56cca84b6084f4d6bcbaca4/bundle/index.js#L37702

Workaround

My current workaround is to use dynamic import inside a new Function() (because dynamic import isn't supported either). I have to change to code into this:

https://github.com/CatChen/eslint-suggestion-action/blob/927208b2e684b1a7c721f4a0e70d4f4e8c11c228/src/getESLint.ts#L15-L26

Guida contributor

Direzione di ricerca: Confronta l'output bundle tra le versioni 0.38.1 e 0.38.2 per il pattern di require dinamico. Identifica cosa è cambiato nella gestione dei require dinamici da parte di ncc e individua la modifica del codice che ha causato la regressione.
Tech stack: javascript
Dominio: build system
Tipo issue: Bug
Difficoltà: 3
Tempo stimato: Mezza giornata
Stato attività: Attiva
Chiarezza: Chiara
Prerequisiti: JavaScriptNode.jsncc
Adatta ai principianti: 40