vercel/hyper

Request: add "tab:close" shortcut

Open

Aperta il 28 mar 2019

Vedi su GitHub
 (8 commenti) (0 reazioni) (0 assegnatari)TypeScript (44.582 star) (3558 fork)batch import
help wanted🎨 Type: Enhancement

Descrizione

Per https://github.com/zeit/hyper/blob/master/app/keymaps/win32.json, there is no shortcut to close tabs.

Adding "tab:close": "ctrl+w", to keymaps doesn't work.

Could you please add a "tab: close" shortcut?

Hyper 3 Canary 8, Windows 10.0.18860.0, can't see this reported in any other issue.

Guida contributor

Tech stack
typescriptjavascriptelectron
Dominio
desktop
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Familiarity with Hyper terminalBasic knowledge of Electron keyboard shortcutsUnderstanding of JSON keymaps
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
65
Direzione di ricerca
Investigate how keyboard shortcuts are defined and registered in Hyper. Start by examining the keymaps file at `app/keymaps/win32.json` and similar files for other platforms. Look for the code that parses these keymaps and binds shortcuts, likely in the main process. The user reported that manually adding the entry did not work, so there may be a missing handler or conflict that needs to be resolved.