vercel/hyper

Add Hyper CLI to user PATH without reboot needing

Open

Aperta il 15 apr 2018

Vedi su GitHub
 (14 commenti) (4 reazioni) (1 assegnatario)TypeScript (44.582 star) (3558 fork)batch import
good first issuehelp wanted⌨️ CLI tool🖼 Platform: Windows

Descrizione

We are currently adding Hyper CLI path to user PATH in Windows registry: https://github.com/zeit/hyper/blob/262eb8ad9b7b9b15351f331765151538d67a09e2/app/utils/cli-install.js#L49-L91

A caveat is that environment variables are cached and users should open and validate "Edit environment variables for your account" dialog to force a cache refresh (or simply reboot their workstation).

@Stanzilla gave a link that could help to improve this: https://stackoverflow.com/a/11955920

Guida contributor

Tech stack
javascripttypescriptnodejs
Dominio
clidesktop
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Windows registryNode.jsenvironment variables
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
The issue targets the file `app/utils/cli install.js` in the Hyper repository, specifically the function that updates the user PATH via Windows registry. The goal is to avoid requiring a reboot or manual refresh of environment variables. Research the StackOverflow link provided (https://stackoverflow.com/a/11955920) which suggests broadcasting a `WM SETTINGCHANGE` message using `SendMessageTimeout` or calling `SetEnvironmentVariable` with appropriate flags. Implement a solution that applies the PATH change and immediately notifies the system to refresh the environment cache, potentially by using a native Node.js addon or child process to invoke Windows API functions.