metrics: rename memory enrichment table counters to end with _total · vectordotdev/vector#25455

(5 commenti) (0 reazioni) (0 assegnatari)Rust (2126 fork)batch import

domain: enrichment_tablesdomain: metricsgood first issuesource: internal_metrics

Metriche repository

Star: (21.837 star)
Metriche merge PR: (Merge medio 8g 16h) (110 PR mergiate in 30 g)

Descrizione

Summary

Three counter metrics in the memory enrichment table are missing the _total suffix, violating the instrumentation spec.

From docs/specs/instrumentation.md: "Counters MUST end with total"

Metrics to rename

Current name	Correct name
`memory_enrichment_table_failed_insertions`	`memory_enrichment_table_failed_insertions_total`
`memory_enrichment_table_failed_reads`	`memory_enrichment_table_failed_reads_total`
`memory_enrichment_table_ttl_expirations`	`memory_enrichment_table_ttl_expirations_total`

These are defined in lib/vector-common/src/internal_event/metric_name.rs as CounterName variants. Their descriptions already say "The total number of..." confirming the intent was to follow the _total convention.

Notes

These are breaking changes for anyone scraping these metrics directly. The old names should be kept as deprecated aliases or the rename should be accompanied by a changelog entry.

Guida contributor

Direzione di ricerca: Trova l'enumerazione CounterName in lib/vector common/src/internal event/metric name.rs, rinomina le tre varianti per terminare con total e assicurati che i vecchi nomi siano mantenuti come alias deprecati secondo la specifica.
Tech stack: rust
Dominio: backend
Tipo issue: Bug
Difficoltà: 2
Tempo stimato: 1-3 ore
Stato attività: Attiva
Chiarezza: Chiara
Prerequisiti: Git
Adatta ai principianti: 75