valyala/fasthttp

Request loses host information after calling RequestURI method

Open

Aperta il 28 ott 2020

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)Go (21.741 star) (1755 fork)batch import
help wanted

Descrizione

Hello,

First, I would like to thank you for this awesome library.

I'm not sure if this is an issue but I noticed this. On the Request struct, il you call the RequestURI method, the Host method won't return anything after that.

It is really easy to reproduce :

package main

import (
	"github.com/valyala/fasthttp"
)

func main() {
	request := &fasthttp.Request{}
	request.SetRequestURI("http://example.com/test-1")

	println(string(request.Host()))
	println(string(request.RequestURI()))
	println(string(request.Host()))
}

This outpouts :

example.com
/test-1

As it should oupout in my opinion :

example.com
/test-1
example.com

For those who could experience the same issue, a workaround is to call instead :

request.URI().RequestURI()

But I would like to know if this is an issue or if this is the normal behavior. If this is the normal behavior, it should probably be documented :) Otherwise, I might be able to send you a PR to fix this if you want.

Thank you in advance for your help.

Guida contributor

Tech stack
go
Dominio
backend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Go programmingfasthttp library basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
The bug is in the RequestURI method, which seems to modify the internal URI representation causing Host() to return empty after the call. Investigate the implementation of RequestURI in the fasthttp package, specifically how it sets the request URI and whether it properly preserves the host information. Check the URI struct and the Host method to understand the data flow. Look at existing tests for URI handling and consider creating a minimal reproduction test. The fix likely involves ensuring that setting the request URI updates the host field accordingly.