valyala/fasthttp

How to integrate fasthttp client with opentracing gracefully

Open

Aperta il 7 apr 2020

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)Go (21.741 star) (1755 fork)batch import
help wanted

Descrizione

net/http expose RoundTrip so it can integrate with opentracing by overwrite the RoundTrip function. while fasthttp client don't implement such interface and do not provide middleware. The only way to integrate with opentracing is overwrite all method of fasthttp client, but it is not graceful.

Guida contributor

Tech stack
go
Dominio
backendobservability
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Go programmingKnowledge of OpenTracing conceptsFamiliarity with fasthttp client
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
45
Direzione di ricerca
The issue requests a graceful way to integrate OpenTracing with the fasthttp client, similar to net/http's RoundTrip mechanism. Research the net/http opentracing integration in opentracing contrib/go stdlib (nethttp/client.go) to understand the approach. Examine fasthttp's client source code (client.go) to identify where a middleware or interceptor could be added without compromising performance. Consider designing a client wrapper or method level hooks. Discuss the proposed design with maintainers in the issue comments.