valyala/fasthttp

Chunked response with trailer result in "cannot find crlf at the end of chunk" error

Open

Aperta il 21 ago 2021

Vedi su GitHub
 (1 commento) (1 reazione) (0 assegnatari)Go (21.741 star) (1755 fork)batch import
help wanted

Descrizione

Hello,

While using fasthttp.Client to talk to a server that produce chunked response with trailer headers I see "cannot find crlf at the end of chunk" error. I suspects that this happens because fasthttp's implementation does not expect to see trailer headers after the last chunk, which is not according to chunked transfer coding spec.

This can ideally be fixed by adding https://github.com/valyala/fasthttp/issues/210. Otherwise readBodyChunked need to be mindful of trailers.

Let me know if I should produce an example.

Regards.

Guida contributor

Tech stack
go
Dominio
api
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
HTTP chunked transfer encodingGo language basicsfasthttp library structure
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
Review the chunked transfer encoding RFC and the `readBodyChunked` function in `http.go` or similar file. Investigate how trailers are currently handled and whether the fix from issue #210 (trailer support) can be integrated. Consider adding logic to parse trailer headers after the terminating chunk.