valhalla/valhalla

docker: trap SIGTERM in valhalla_route_service

Open

#634 aperta il 30 mar 2017

Vedi su GitHub
 (10 commenti) (1 reazione) (1 assegnatario)C++ (904 fork)github user discovery
enhancementhelp wanted

Metriche repository

Star
 (5789 star)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

heya, I've been running valhalla using Docker and docker-compose.

when running the docker-compose down command a SIGTERM signal is first sent to the process and then it waits an interval (default 10s) before sending it a SIGKILL.

it seems like valhalla_route_service is ignoring the SIGTERM signal.

because of how docker runs the process as PID 1 it behaves a little differently regarding trapping signals, it might require that the signal is explicitly trapped with code.

eg: (in nodejs):

process.on('SIGTERM', function(){ app.close(); });

the benefit is that valhalla docker containers would restart almost instantly, rather than waiting ~10s for the SIGKILL.

Guida contributor