vaadin/framework

Deprecate MultiSelectionEvent.getNewSelection

Aperta

#11.756 aperta il 23 ott 2019

 (1 commento) (1 reazione) (0 assegnatari)Java (715 fork)auto 404
Help wantedStale

Metriche repository

Star
 (1806 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Description copied from https://github.com/vaadin/flow/issues/6756

The class has three methods for the same thing:

Set<T> getValue()
Set<T> getAllSelectedItems()
Set<T> getNewSelection()

The first two are inherited, but getNewSelection exists only in MultiSelectionEvent.

Another reason to deprecate it is that the naming can cause confusion. We got feedback that a user expected the method to return the newly added items (compared to the old selection), i.e. what getAddedSelection returns.

JavaDocs should suggest to use getAllSelectedItems or getValue instead.

Guida contributor