usebruno/bruno

Consider using stronger ACL on Environment files

Open

Aperta il 4 apr 2024

Vedi su GitHub
 (1 commento) (1 reazione) (0 assegnatari)JavaScript (43.787 star) (2403 fork)batch import
good first issuehelp wantedmodule-environmentsmodule-filesystemmodule-security

Descrizione

Issue

When an Environment file is created, it is typically stored in the environments directory. On 'nix/BSD environments, those files are stored with world-readable perms (644 to be exact). While there is already some protection for sensitive data by using the "Secrets" checkbox, I could see people who accidentally/mistakenly still store sensitive creds and keys which could expose them.

I'd recommend you set an ACL for the Environment files to 600 by default. I can confirm that Bruno will continue to read and write to them just fine with those permissions set.

Guida contributor

Tech stack
javascriptelectron
Dominio
securitydesktop
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Node.js file systemchmod usage
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
75
Direzione di ricerca
The issue proposes modifying the default file permissions for environment files from 644 to 600. Look for the code that creates environment files, likely in the app's file handling modules. The change is straightforward: set the file mode to 0o600 when writing. Test that reading and writing still works after the change.