umputun/remark42

Separate vendor from widgets bundles

Open

Aperta il 25 feb 2021

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)Go (5500 star) (432 fork)user submission
enhancementfrontendgood-first-issuehelp wanted

Descrizione

It's a really good thing in the case when remark42 installed on a page with the two widgets comments and last comments. Both of the widgets have bundles that include preact, redux, etc. It could be much more effective to separate vendor bundle and use the same piece of code for these widgets.

Guida contributor

Tech stack
javascripttypescriptgo
Dominio
frontendperformance
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
familiarity with Go build systemunderstanding of JavaScript bundling
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
30
Direzione di ricerca
Investigate the current build process in the repository, likely involving Webpack or a similar bundler for the frontend widgets. Identify the common vendor dependencies (e.g., preact, redux) shared between 'comments' and 'last comments' widgets. Then propose splitting the vendor code into a separate bundle that can be cached and reused. Look for existing build configurations in the repository, such as webpack.config.js or Makefile, and study how bundles are currently generated. The implementation should ensure backward compatibility and maintain the existing widget APIs.