umputun/remark42

Disabling negative voting result causes lack of signs

Open

Aperta il 7 giu 2020

Vedi su GitHub
 (6 commenti) (1 reazione) (0 assegnatari)Go (5500 star) (432 fork)user submission
frontendgood-first-issuehelp wanted

Descrizione

Enabling POSITIVE_SCORE changes existing votes as well. This is expected (I guess) but confusing side-effect.

Not sure how to deal with this, but can think of 3 possible solutions:

  1. do nothing
  2. UI not just loose +/- on POSITIVE_SCORE, but also shows all negative values as 0s
  3. UI checks if any vote for the post negative and shows +/- in this case (POSITIVE_SCORE mode only)

/cc @paskal @akellbl4 @Mavrin

Guida contributor

Tech stack
gojavascript
Dominio
frontend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
basic Gofrontend development
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
The issue concerns the display of vote signs when POSITIVE SCORE is enabled. The frontend code (likely in a React component) renders vote icons and should be modified to either show negative values as 0 or conditionally show signs. The backend logic for POSITIVE SCORE is in the Go code. Look at the current implementation of vote display and the handling of the POSITIVE SCORE flag. The maintainer comments may provide additional guidance.