umputun/remark42

Tweet embedding

Aperta

#355 aperta il 26 giu 2019

 (4 commenti) (0 reazioni) (1 assegnatario)Go (432 fork)user submission
enhancementfrontendhelp wanted

Metriche repository

Star
 (5500 stelle)
Metriche merge PR
 (Merge medio 87g 10h) (18 PR mergiate in 30 g)

Descrizione

Twitter supports embeding functionally by making smth like this

<blockquote class="twitter-tweet"><p lang="en" dir="ltr">
Dear tech bloggers,<br>Please stop using Foo, Bar, Baz, Fizz, Buzz, etc. when writing tutorials.
Use names of real things with context that make it easier to understand.</p>&mdash; Vx. 
CodePirate (@michelecynowicz) <a href="https://twitter.com/michelecynowicz/status/1142413927910912000?ref_src=twsrc%5Etfw">June 22, 2019</a></blockquote>
<script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>

Obviously, such a thing will be stripped by remark42 as we don't allow any js in. Result looks like this:

for &mdash; I have opened #354

Can we make such embedded tweets looks a little bit better, maybe even formatted the way twitter shows it but without that widget? I'm not sure if we care but if UI guys can figure a nice way to do it will be glad to hear the idea.

Guida contributor