umputun/remark42

Problematic logout doesn't show errors in the UI

Open

Aperta il 31 lug 2022

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)Go (5500 star) (432 fork)user submission
bugfrontendhelp wanted

Descrizione

I run remark42 like that: ./remark42.darwin-arm64 server --secret=12345 --url=http://127.0.0.1:8080.

If I was logged in before running that version (with no auth providers) I see a normal comment screen:

If I push the "log out" button, http://127.0.0.1:8080/auth/logout?site=remark request is made with status code 400 which has the following answer:

{
    "error": "providers not defined"
}

The interface shows nothing. In the console, I see the following:

Erroring code:

Guida contributor

Tech stack
javascriptreactgo
Dominio
full stack
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Basic knowledge of GoBasic knowledge of React
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
65
Direzione di ricerca
The issue is that the frontend does not display the error response from the logout API. The error from the backend is a 400 with 'providers not defined'. The frontend code that handles the logout response likely needs to catch and display this error. Look at the frontend's logout function (probably in a component that handles authentication) and ensure it shows the error message.