ucsd-progsys/liquidhaskell

"Incomplete patterns" error with GHC <9.0.1

Open

#1918 aperta il 1 dic 2021

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)Haskell (157 fork)batch import
good first issue

Metriche repository

Star
 (1306 star)
Metriche merge PR
 (Merge medio 2g 18h) (12 PR mergiate in 30 g)

Descrizione

GHC 8.10.7 but not GHC 9.0.1 reports "Pattern match(es) are non-exhaustive" in a few places.

https://github.com/ucsd-progsys/liquidhaskell/pull/1915 added {-# OPTIONS_GHC -Wno-incomplete-patterns #-} to files where this erroneous warning was reported since they are all false positives.

This ticket should be resolved by either investigating the root cause of the erroneous warning under GHC 8.10.7 and fixing it, or by waiting until we're happy to drop support for GHC <9.0.1. Either way, this ticket should not be marked as resolved before all -Wno-incomplete-patterns are removed from the code base: the pattern exhaustiveness check is generally a Good Thing and should not stay disabled longer than absolutely necessary!

Guida contributor