twitter/finagle

Add com.twitter.finagle.zipkin.core.Endpoint.ipv6

Open

#526 aperta il 13 lug 2016

Vedi su GitHub
 (6 commenti) (0 reazioni) (0 assegnatari)Scala (1435 fork)batch import
good first issue

Metriche repository

Star
 (8864 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

We currently support logging of only IPv4 addresses. Starting with Zipkin 1.4, endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address. https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift#L276

It looks like the most pivotal change is updating com.twitter.finagle.zipkin.core.Endpoint.ipv6

cc @sveinnfannar

Guida contributor