trixi-framework/Trixi.jl

Make axis labels created by `PlotDataXD` objects more flexible

Open

Aperta il 22 mag 2021

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)Julia (686 star) (153 fork)batch import
enhancementgood first issuevisualization

Descrizione

Right now, axis labels for plotting with Plots.jl are automatically determined to be x, y, or z (see _get_dimensions and _get_guides in src/visualization/plot_recipes.jl). This precludes using PlotData1D from using it conveniently for something like TimeSeriesCallback results.

A possible approach would be to store the axis labels with the PlotDataXD objects depending on from which data source they were created, instead of determining the labels on the fly at plot time.

Guida contributor

Tech stack
Nessuno
Dominio
data
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Julia knowledgeTrixi.jl basicsPlots.jl experience
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
45
Direzione di ricerca
Investigate the current implementation in `src/visualization/plot recipes.jl` specifically the ` get dimensions` and ` get guides` functions. Understand how axis labels are currently determined from PlotDataXD objects. Then explore modifying the PlotDataXD constructors to store custom axis labels based on the data source. Consider adding tests for the new flexibility.