tikv/raft-engine

Key value tombstone is lost during rewrite

Aperta

#141 aperta il 8 nov 2021

 (0 commenti) (0 reazioni) (0 assegnatari)Rust (106 fork)auto 404
bughelp wanted

Metriche repository

Star
 (632 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Bug Report

Description

During Append queue rewrite, key value pairs of targeted Raft groups are scanned out and rewritten to Rewrite queue. After that, data files in Append queue is deleted.

However, in this process, key value tombstones (delete key operation) can't be detected and rewritten. Suppose rewrite is triggered after a Put and before a later Delete, the old key value is stored in Rewrite queue, but the subsequent deletion marker is purged from Append queue. When the engine restarts, the old key value will re-surface.

Right now, TiKV doesn't use kv delete API, so this bug is of minor urgency.

Guida contributor