tektoncd/pipeline

feat(tracing): add spans to timeout and cancellation code paths

Aperta

#9783 aperta il 16 apr 2026

 (2 commenti) (0 reazioni) (0 assegnatari)Go (1943 fork)auto 404
good first issuekind/feature

Metriche repository

Star
 (9013 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Feature request

Add OpenTelemetry spans to the PipelineRun cancellation and timeout helpers. These code paths have zero tracing, making it impossible to trace why a run was stopped or how long child-patching took.

Use case

When a PipelineRun times out, the trace ends abruptly. Adding spans to the cancel/timeout functions reveals: which children were patched, how long each patch took, and whether graceful cancellation triggered finally tasks.

Implementation hints

PipelineRun — pkg/reconciler/pipelinerun/cancel.go:

  • cancelPipelineRun — marks PR cancelled, patches all children
  • gracefullyCancelPipelineRun — cancels tasks but triggers finally
  • cancelPipelineTaskRunsForTaskNames — iterates children, patches each
  • cancelTaskRun / cancelCustomRun — individual child patches

PipelineRun — pkg/reconciler/pipelinerun/timeout.go:

  • timeoutPipelineRun — marks PR timed out, patches all children
  • timeoutPipelineTasksForTaskNames — iterates children, patches each
  • timeoutTaskRun / timeoutCustomRun — individual child patches

TaskRun — pkg/reconciler/taskrun/taskrun.go:

  • Line 185: IsCancelled() branch — add span attribute reason=Cancelled
  • Line 199: HasTimedOut() branch — add span attribute reason=TimedOut

Part of umbrella: #9701

good first issue — well-scoped files (cancel.go + timeout.go), clear functions.

Guida contributor